This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[tool] Include dev_dependencies in make-deps-path-based
#6146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pathifying dependencies using `make-deps-path-based`, consider `dev_dependencies` in addition to `dependencies`. This handles cases such as `go_router`/`go_router_builder`. The lack of this caused flutter/flutter#108274 to slip through presubmit tests.
loic-sharma
approved these changes
Jul 25, 2022
11 tasks
stuartmorgan-g
added
the
autosubmit
johnpryan
approved these changes
Jul 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pathifying dependencies using
make-deps-path-based, considerdev_dependenciesin addition todependencies. This handles casessuch as
go_router/go_router_builder.The lack of this caused flutter/flutter#108274
to slip through presubmit tests.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).