Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Bump kotlin to 1.7.10 #6228

Merged
merged 1 commit into from
Aug 11, 2022
Merged

[path_provider] Bump kotlin to 1.7.10 #6228

merged 1 commit into from
Aug 11, 2022

Conversation

GaryQian
Copy link
Contributor

Fixes flutter/flutter#109397 after large gradle bump in #6189

@GaryQian GaryQian requested a review from camsim99 as a code owner August 11, 2022 17:41
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

camsim99
camsim99 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

christopherfujino
christopherfujino approved these changes Aug 11, 2022
View reviewed changes
Copy link

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaryQian GaryQian added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 11, 2022
@GaryQian
Copy link
Contributor Author

Landing to fix tree

@GaryQian GaryQian merged commit 411d1ed into flutter:main Aug 11, 2022
@christopherfujino
Copy link

@GaryQian FYI the waiting for tree to go green label has been deprecated, autosubmit is the new hotness.

@christopherfujino christopherfujino mentioned this pull request Aug 11, 2022
Closed
@GaryQian
Copy link
Contributor Author

Ahh! Ok, I've been seeing Autosubmit, was not aware of the formal switch to it. Thanks!

@christopherfujino christopherfujino mentioned this pull request Aug 12, 2022
Merged
11 tasks
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
@GaryQian @yutaaraki-toydium
[path_provider] Bump kotlin to 1.7.10 (flutter#6228)
14cb6bd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
411d1eda0 [path_provider] Bump kotlin to 1.7.10 (flutter/plugins#6228)
ab52427
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@GaryQian @moisefeelin
[path_provider] Bump kotlin to 1.7.10 (flutter#6228)
056dac6
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@GaryQian @mauricioluz
[path_provider] Bump kotlin to 1.7.10 (flutter#6228)
1809738
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@camsim99 camsim99 camsim99 approved these changes

Assignees
No one assigned
Labels
needs tests p: path_provider platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade of package:path_provider_android broke flutter_engine_group_performance test
3 participants
@GaryQian @christopherfujino @camsim99