Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Include the missing GetDirectoryPath method example and table of supported platforms #6454

Merged

Conversation

VanesaOshiro
Copy link
Contributor

@VanesaOshiro VanesaOshiro commented Sep 19, 2022

Adds the following:

  • Table of supported platforms
  • The missing GetDirectoryPath method example

image
Table of supported platforms

image
GetDirectoryPath method example

Related issue:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! See inline for comments.

@VanesaOshiro VanesaOshiro force-pushed the 65844-add-description-of-methods branch 2 times, most recently from e6d8afb to 6031fcd Compare September 20, 2022 14:51
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@VanesaOshiro
Copy link
Contributor Author

Thanks for the submission! See inline for comments.

Hello Stuart! Thanks for your feedback, I've made the necessary changes, please feel free to review again. On the other hand, the bot has assigned the "needs tests" label, but I've only updated the documentation, so some hours ago I sent a request for test exemption.

@Hixie
Copy link
Contributor

Hixie commented Sep 21, 2022

test-exempt: documentation

@VanesaOshiro VanesaOshiro force-pushed the 65844-add-description-of-methods branch from 6031fcd to 79ce169 Compare September 23, 2022 13:18
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small nits, but otherwise looks good!

@stuartmorgan-g
Copy link
Contributor

@cbracken for secondary review

@VanesaOshiro VanesaOshiro force-pushed the 65844-add-description-of-methods branch from 79ce169 to 3be7a04 Compare September 27, 2022 12:50
@VanesaOshiro
Copy link
Contributor Author

A few more small nits, but otherwise looks good!

We've applied the suggested changes, thanks!

@VanesaOshiro VanesaOshiro force-pushed the 65844-add-description-of-methods branch 2 times, most recently from c34f95a to 83e93fb Compare October 6, 2022 19:19
@VanesaOshiro VanesaOshiro force-pushed the 65844-add-description-of-methods branch from 83e93fb to f5cb8cb Compare October 19, 2022 11:41
@VanesaOshiro VanesaOshiro force-pushed the 65844-add-description-of-methods branch from f5cb8cb to b21dace Compare October 19, 2022 17:08
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit auto-submit bot merged commit 655599b into flutter:main Oct 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: file_selector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants