-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[file_selector] Include the missing GetDirectoryPath method example and table of supported platforms #6454
[file_selector] Include the missing GetDirectoryPath method example and table of supported platforms #6454
Conversation
235dd8e
to
fac8fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! See inline for comments.
e6d8afb
to
6031fcd
Compare
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hello Stuart! Thanks for your feedback, I've made the necessary changes, please feel free to review again. On the other hand, the bot has assigned the "needs tests" label, but I've only updated the documentation, so some hours ago I sent a request for test exemption. |
test-exempt: documentation |
6031fcd
to
79ce169
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small nits, but otherwise looks good!
@cbracken for secondary review |
79ce169
to
3be7a04
Compare
We've applied the suggested changes, thanks! |
c34f95a
to
83e93fb
Compare
83e93fb
to
f5cb8cb
Compare
f5cb8cb
to
b21dace
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… example and table of supported platforms (flutter/plugins#6454)
… example and table of supported platforms (flutter/plugins#6454)
…nd table of supported platforms (flutter#6454)
…nd table of supported platforms (flutter#6454)
Adds the following:
Table of supported platforms
GetDirectoryPath method example
Related issue:
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.