Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tools] Add 'run_tests.sh' to the dev-only list #6474

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

Ensures that run_tests.sh changes are treaded as developer-only files,
so that they won't trigger version and changelog requirements.

Fixes flutter/flutter#112215

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Ensures that `run_tests.sh` changes are treaded as developer-only files,
so that they won't trigger version and changelog requirements.

Fixes flutter/flutter#112215
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some warnings in here about newer versions for dependancies. Not sure how those are handled, but the pr seems good otherwise!

@stuartmorgan-g
Copy link
Contributor Author

Those show up all over the place; the UI for that check isn't great. We need to clean it up at some point so it doesn't flag things we don't care about.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2022
@auto-submit auto-submit bot merged commit 376a64f into flutter:main Sep 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flutter_plugin_tools] Exempt run_tests.sh from version changes
2 participants