Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Enable depend_on_referenced_packages lint #6498

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Enable depend_on_referenced_packages lint #6498

merged 1 commit into from
Sep 26, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

Enables the depend_on_referenced_packages to better align with flutter/flutter, and fixes all violations.

The violations are all in example/ pubspecs, since publishing catches non-example violations.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
Enable depend_on_referenced_packages lint
011ca5a 
Enables the `depend_on_referenced_packages` to better align with
flutter/flutter, and fixes all violations.

The violations are all in example/ pubspecs, since publishing catches
non-example violations.

Part of flutter/flutter#76229
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor Author

Sorry for the review spam; this is a downside of having CODEOWNERS :( This just needs one review from whoever gets to it first.

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Sep 26, 2022
@stuartmorgan-g
Copy link
Contributor Author

(Filed flutter/flutter#112410 for the changelog flag)

@Hixie
Copy link
Contributor

Hixie commented Sep 26, 2022

test-exempt: enables lint

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2022
@auto-submit auto-submit bot merged commit 8ef3001 into flutter:main Sep 26, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2022
@engine-flutter-autoroll
8ef30019e Enable depend_on_referenced_packages lint (flutter/plugins#…
8f47ec8 
…6498)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@stuartmorgan-g
Enable depend_on_referenced_packages lint (flutter#6498)
772e659
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan-g @mauricioluz
Enable depend_on_referenced_packages lint (flutter#6498)
1be689a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@jmagman jmagman Awaiting requested review from jmagman jmagman is a code owner

@GaryQian GaryQian Awaiting requested review from GaryQian

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: camera p: file_selector p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: path_provider p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios platform-linux platform-macos platform-web platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan-g @Hixie @hellohuanlin