[file_selector] Annotate all parameters of XTypeGroup with // ignore: prefer_const_literals_to_create_immutables

[eugerossetto]

Annotate all parameters of XTypeGroup with // ignore: prefer_const_literals_to_create_immutables to prepare this implementation for the const constructor of XTypeGroup. On files that have more than two occurrences, an ignore_for_file was added at the top of the file.

Issue:
#111906 [file_selector] XTypeGroup should be immutable

Related PR:
[file_selector] Convert XTypeGroup to const

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[stuartmorgan-g]

I hadn't looked at the details of what was still failing. These don't need an ignore, you can just add the consts now since everything that generates this lint warning has a const constructor already.

[eugerossetto]

I hadn't looked at the details of what was still failing. These don't need an ignore, you can just add the consts now since everything that generates this lint warning has a const constructor already.

Hi Stuart, do you think it would be a better approach to use const parameters instead of ignoring the warnings? Then, the desired change it's going to look like this:

final XTypeGroup typeGroup = XTypeGroup(
      label: 'images',
      extensions: const <String>['jpg', 'jpeg'],
      mimeTypes: const <String>['image/png'],
      webWildCards: const <String>['image/*'],
);

Since the PR that updates the constructor hasn't been merged yet, it won't be OK to use a const constructor at this moment.
Am I missing something?
Thanks.

[stuartmorgan-g]

I was thinking we should just do it that way since we'd need to make that change regardless, but I guess once we make XTypeGroup's construction const we won't need the sub-consts. So that would be more churn, not less; sorry about that.

LGTM with the temporary ignores.

[stuartmorgan-g]

@ditman Can you do the secondary approval here?