Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Re-land Add ProcessCameraProvider class to CameraX Plugin #6508

Merged
merged 17 commits into from
Sep 29, 2022

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Sep 28, 2022

Re-lands #6469. Differences between this PR and original:

  • dependency block is moved outside of android block in the Gradle configuration file.
  • getInstanceTest in ProcessCameraProviderTest.java is fixed since the previous changed caused a failure.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@camsim99 camsim99 changed the title [camera][wip] Fix CameraX plugin build.gradle [camera] Re-land Add ProcessCameraProvider class to CameraX Plugin Sep 29, 2022
@camsim99 camsim99 marked this pull request as ready for review September 29, 2022 16:26
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants