Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Fix potential timeouts in the integration tests #6869

Closed
wants to merge 2 commits into from

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 20, 2022

Copy of fix for webview_flutter and webview_Flutter_android: #6857

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Dec 20, 2022
@bparrishMines bparrishMines changed the title Update ios integration test [webview_flutter_wkwebview] Fix potential timeouts in the integration tests Dec 20, 2022
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, CI is failing on XCUITests and seems unrelated:

Test Case '-[FLTWebViewUITests testTransparentBackground]' started.
    t =     0.00s Start Test at 2022-12-20 10:24:22.169
    t =     0.06s Set Up
    t =     0.06s     Open dev.flutter.plugins.webviewFlutterExample
    t =     0.08s         Launch dev.flutter.plugins.webviewFlutterExample
    t =     0.29s             Setting up automation session
    t =     2.48s             Wait for dev.flutter.plugins.webviewFlutterExample to idle
    t =     4.01s Waiting 30.0s for "Show menu" Button to exist
    t =     5.09s     Checking `Expect predicate `exists == 1` for object "Show menu" Button`
    t =     5.09s         Checking existence of `"Show menu" Button`
    t =     5.16s Tap "Show menu" Button
    t =     5.16s     Wait for dev.flutter.plugins.webviewFlutterExample to idle
    t =     6.38s     Find the "Show menu" Button
    t =     6.41s     Check for interrupting elements affecting "Show menu" Button
    t =     6.44s     Synthesize event
    t =     6.85s     Wait for dev.flutter.plugins.webviewFlutterExample to idle
    t =     6.89s Waiting 30.0s for "Transparent background example" Button to exist
    t =     7.92s     Checking `Expect predicate `exists == 1` for object "Transparent background example" Button`
    t =     7.92s         Checking existence of `"Transparent background example" Button`
    t =     7.96s Tap "Transparent background example" Button
    t =     7.96s     Wait for dev.flutter.plugins.webviewFlutterExample to idle
    t =     7.98s     Find the "Transparent background example" Button
    t =     8.04s     Check for interrupting elements affecting "Transparent background example" Button
    t =     8.08s     Synthesize event
    t =     8.39s     Wait for dev.flutter.plugins.webviewFlutterExample to idle
    t =     8.44s Waiting 30.0s for "Transparent background test" StaticText to exist
    t =     9.49s     Checking `Expect predicate `exists == 1` for object "Transparent background test" StaticText`
    t =     9.49s         Checking existence of `"Transparent background test" StaticText`
/Volumes/Work/s/w/ir/x/w/plugins/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerUITests/FLTWebViewUITests.m:85: error: -[FLTWebViewUITests testTransparentBackground] : ((CGColorEqualToColor(redColor, centerColor.CGColor)) is true) failed

@stuartmorgan-g
Copy link
Contributor

@bparrishMines Does this just need the latest main merged in?

@bparrishMines
Copy link
Contributor Author

Possibly. I wanted to explore the flake that @cyanglaz pointed out. But it could end up just being fixed after pulling from main. I'll try.

@bparrishMines
Copy link
Contributor Author

Fixed in #6996

@bparrishMines bparrishMines deleted the ios_test_fix branch January 31, 2023 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: webview_flutter Edits files for a webview_flutter plugin platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants