This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ci] Add LUCI versions of macOS ARM tests #6984
Merged
stuartmorgan-g
merged 8 commits into
flutter:main
from
stuartmorgan-g:luci-arm64-macos-initial
Jan 30, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
354f270
[ci] Add an initial macOS ARM LUCI test
stuartmorgan-g 8f5aeaa
Update for filename rename
stuartmorgan-g caf7775
Try presubmit
stuartmorgan-g ebdaf74
Re-add bringup
stuartmorgan-g 6314d0b
Merge branch 'main' into luci-arm64-macos-initial
stuartmorgan-g 275b7c2
Rename iOS platform tests to be less confusing
stuartmorgan-g c08fb7d
Add macOS platform tests too
stuartmorgan-g 91e0dcd
Fix arch
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| - name: create all_plugins app | ||
| script: .ci/scripts/create_all_plugins_app.sh | ||
| - name: build all_plugins for iOS debug | ||
| script: .ci/scripts/build_all_plugins.sh | ||
| args: ["ios", "debug", "--no-codesign"] | ||
| - name: build all_plugins for iOS release | ||
| script: .ci/scripts/build_all_plugins.sh | ||
| args: ["ios", "release", "--no-codesign"] |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| - name: build examples | ||
| script: script/tool_runner.sh | ||
| args: ["build-examples", "--macos"] | ||
| - name: xcode analyze | ||
| script: script/tool_runner.sh | ||
| args: ["xcode-analyze", "--macos"] | ||
| - name: xcode analyze deprecation | ||
| # Ensure we don't accidentally introduce deprecated code. | ||
| script: script/tool_runner.sh | ||
| args: ["xcode-analyze", "--macos", "--macos-min-version=12.3"] | ||
| - name: native test | ||
| script: script/tool_runner.sh | ||
| args: ["native-test", "--macos"] | ||
| - name: drive examples | ||
| script: script/tool_runner.sh | ||
| args: ["drive-examples", "--macos", "--exclude=script/configs/exclude_integration_macos.yaml"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second space doesn't messing up the recipe script, right? I can picture a bug related to splitting on the spaces to parse
Mac_arm64, but I didn't look.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the format we've been using for all of the packages and plugins LUCI tasks, and the script has been happy with it. Infra folks helped set up the initial naming structure.