-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] Expose auto exposure and auto focus point of interest functionality (iOS only) #709
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
Who needs to look at this to get it merged? |
@kroikie who needs to review this so I can get it merged? I just had to update for a style guide change, I'd rather get this soon to avoid extra maintenance. Thanks! |
@hariprasadiit I would love to get this merged, but I haven't been able to get anyone to review or even comment. What can I do to help this along? |
When can this be merged, people? |
There is no implementation in this PR for Android. Instead of merging, we should look for people to implement the Android part before merging. |
I recently bought an Android device that I can use for building and testing an Android implementation of this PR in the next few weeks if no one gets to it sooner |
Hi, how is the progress for Android coming along? Also, is there a way to get auto focus enabled for this plugin? |
@jdeltoft I haven't had a chance to work on it, but I should be able to knock it out sometime in the next few weeks. This PR implements setting the auto focus/point of interest in screen coordinates, but if you want to implement something like Google's camera app for Android with more advanced auto focus, that's beyond the scope of what I'm working on here. |
@lsmith130 What is the progress of Android auto focus? How can I check the camera is focused or not? |
I am wondering if it's gonna be merged soon. |
Looking at this PR, I presume the reason it hasn't been merged is that it is lacking tests. I'm not sure if we yet have the technology to write tests for this kind of plug-in, though. |
@Hixie Unfortunately, we don't have anyone who can look at it right now. However, it is missing an Android implementation and tests usually make it easier to review. But, just like flutterfire plugins that require credentials, we could write tests that would only run locally. cc @mklim |
Adding changes from flutter#709
What is the status of this feature? when will it be merged? |
Please merge this pull request if it is possible! |
holy what happened I need this feature :/ |
I'd love to implement this for Android too, but I don't have a device to test with, and I believe the emulator is a no-go for camera testing.