Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Expose auto exposure and auto focus point of interest functionality (iOS only) #709

Closed
wants to merge 3 commits into from

Conversation

fore5fire
Copy link

I'd love to implement this for Android too, but I don't have a device to test with, and I believe the emulator is a no-go for camera testing.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@fore5fire
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@fore5fire
Copy link
Author

Who needs to look at this to get it merged?

@fore5fire
Copy link
Author

@kroikie who needs to review this so I can get it merged? I just had to update for a style guide change, I'd rather get this soon to avoid extra maintenance. Thanks!

@fore5fire fore5fire changed the title Expose auto exposure and auto focus point of interest functionality (iOS only) [camera] Expose auto exposure and auto focus point of interest functionality (iOS only) Oct 29, 2018
@fore5fire
Copy link
Author

@hariprasadiit I would love to get this merged, but I haven't been able to get anyone to review or even comment. What can I do to help this along?

@TareqElMasriDev
Copy link

TareqElMasriDev commented Dec 20, 2018

When can this be merged, people?

@edwardhuerta
Copy link

There is no implementation in this PR for Android. Instead of merging, we should look for people to implement the Android part before merging.

@fore5fire
Copy link
Author

I recently bought an Android device that I can use for building and testing an Android implementation of this PR in the next few weeks if no one gets to it sooner

@jdeltoft
Copy link

Hi, how is the progress for Android coming along? Also, is there a way to get auto focus enabled for this plugin?

@fore5fire
Copy link
Author

@jdeltoft I haven't had a chance to work on it, but I should be able to knock it out sometime in the next few weeks. This PR implements setting the auto focus/point of interest in screen coordinates, but if you want to implement something like Google's camera app for Android with more advanced auto focus, that's beyond the scope of what I'm working on here.

@Afsalpp
Copy link

Afsalpp commented Aug 19, 2019

@lsmith130 What is the progress of Android auto focus? How can I check the camera is focused or not?

@ianpark
Copy link

ianpark commented Aug 20, 2019

I am wondering if it's gonna be merged soon.

@Hixie
Copy link
Contributor

Hixie commented Dec 10, 2019

Looking at this PR, I presume the reason it hasn't been merged is that it is lacking tests. I'm not sure if we yet have the technology to write tests for this kind of plug-in, though.

cc @bparrishMines @collinjackson

@bparrishMines
Copy link
Contributor

@Hixie
We prioritize based on customers and the thumbs up found in the issue connected to the PR. In this case, it looks like its this issue: flutter/flutter#24575.

Unfortunately, we don't have anyone who can look at it right now. However, it is missing an Android implementation and tests usually make it easier to review. But, just like flutterfire plugins that require credentials, we could write tests that would only run locally.

cc @mklim

ryanzander added a commit to ryanzander/plugins that referenced this pull request Jan 17, 2020
ryanzander added a commit to ryanzander/plugins that referenced this pull request Jan 17, 2020
@morbyosef
Copy link

What is the status of this feature? when will it be merged?

@iNima
Copy link

iNima commented Feb 4, 2020

Please merge this pull request if it is possible!

@misaelriojasftf
Copy link

holy what happened I need this feature :/

@mvanbeusekom
Copy link
Contributor

Closing as duplicate of #3346 and #3370

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.