This repository was archived by the owner on Dec 19, 2023. It is now read-only.
refactor(capture_page): cubit usage adjustments #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
commented
Feb 17, 2022
| ), | ||
| const SizedBox(height: 55), | ||
| // TODO(Jan-Stepien): implement Need Help button | ||
| TextButton( | ||
| onPressed: context.read<CaptureCubit>().callNeedHelp, | ||
| onPressed: () => context.read<CaptureCubit>().callNeedHelp(), |
There was a problem hiding this comment.
Removing the tear-off because context.read will get call on each build unnecessarily.
felangel
commented
Feb 17, 2022
| ), | ||
| ), | ||
| ), | ||
| BlocSelector<CaptureCubit, CaptureCubitState, bool>( |
There was a problem hiding this comment.
using BlocSelector here to scope rebuilds
7 tasks
Jan-Stepien
reviewed
Feb 17, 2022
Comment on lines
+262
to
+265
| extension on CaptureCubitState { | ||
| bool get isScoreSelected => score != -1; | ||
| bool get canSubmit => score != -1 && chipIndexes.isNotEmpty; | ||
| } |
There was a problem hiding this comment.
hows this better than getters on cubit? i dont really get it
There was a problem hiding this comment.
Extension in the UI indicates that this is purely presentation logic that is "syntactic sugar". I recommend avoiding exposing public methods to query state information from the cubit directly because ideally the cubit should only be accessed in order notify of changes in the UI. Getters on the cubit are error prone because they don't trigger rebuilds when the computed value changes.
There was a problem hiding this comment.
Right, it wont trigger changes and we want to keep the state as a complete definition, i see that, thanks
Jan-Stepien
reviewed
Feb 17, 2022
| ? NpsColors.colorWhite | ||
| : NpsColors.colorPrimary1, | ||
| (index) { | ||
| final isSelected = context.select( |
There was a problem hiding this comment.
this is to reduce of 'watch rebuilds' ? from 2 to 1?
There was a problem hiding this comment.
Yeah I apologize if I was unclear when I said scope the watches as low as possible. I meant scope them to the lowest BuildContext. Having multiple watches on the same context is less efficient than a single top level watch.
There was a problem hiding this comment.
It makes sense,
Im super greatfull for a review, all your comments are very helpful
Jan-Stepien
reviewed
Feb 17, 2022
Jan-Stepien
pushed a commit
that referenced
this pull request
Feb 18, 2022
* Add animations to capture view * button styling changes * fix unit tests * split apptheme to seperate file * implicit scaffold's background theme * use project barrel file * barrel coverage fix * code review fixes * implement PR's comments * theme fix * top level theme * max score in cubit state * move business logic to cubit * add i18n * refactor(capture_page): cubit usage adjustments (#52) * fix tests * localize chip names * fix cubit tests * change row trick into align * medium typo fix * removed * supportedLocales fix * missing trailing coma Co-authored-by: Felix Angelov <[email protected]>
Jan-Stepien
pushed a commit
that referenced
this pull request
Feb 18, 2022
* Add animations to capture view * button styling changes * fix unit tests * split apptheme to seperate file * implicit scaffold's background theme * use project barrel file * barrel coverage fix * feat: responsive capture page * responsiveness test * code review fixes * implement PR's comments * theme fix * top level theme * max score in cubit state * move business logic to cubit * add i18n * refactor(capture_page): cubit usage adjustments (#52) * fix tests * localize chip names * fix cubit tests * change row trick into align * fix tests * medium typo fix * removed * supportedLocales fix * missing trailing coma * empty line * supress gen files Co-authored-by: Felix Angelov <[email protected]>
Jan-Stepien
pushed a commit
that referenced
this pull request
Feb 21, 2022
* Add animations to capture view * button styling changes * fix unit tests * split apptheme to seperate file * implicit scaffold's background theme * use project barrel file * barrel coverage fix * feat: responsive capture page * responsiveness test * feat: implement thank you screen * code review fixes * use FlutterGen for accessing assets * pull request review fixes * implement PR's comments * theme fix * top level theme * max score in cubit state * move business logic to cubit * add i18n * refactor(capture_page): cubit usage adjustments (#52) * fix tests * localize chip names * fix cubit tests * change row trick into align * fix tests * organize imports * medium typo fix * removed * supportedLocales fix * missing trailing coma * capture end page test * exclude assets from flutter gen * ignore gen file * full path Co-authored-by: Felix Angelov <[email protected]>
Jan-Stepien
pushed a commit
that referenced
this pull request
Mar 14, 2022
* Add animations to capture view * button styling changes * fix unit tests * split apptheme to seperate file * implicit scaffold's background theme * use project barrel file * barrel coverage fix * feat: responsive capture page * responsiveness test * feat: implement thank you screen * feat: capture navigation with transition animation * code review fixes * use FlutterGen for accessing assets * pull request review fixes * capture navigation fix * implement PR's comments * theme fix * top level theme * max score in cubit state * move business logic to cubit * add i18n * refactor(capture_page): cubit usage adjustments (#52) * fix tests * localize chip names * fix cubit tests * change row trick into align * fix tests * organize imports * medium typo fix * removed * supportedLocales fix * missing trailing coma * unused import * capture end page test * exclude assets from flutter gen * ignore gen file * full path * cleanup * PR comments resolving Co-authored-by: Felix Angelov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change