Skip to content

[Gallery] Exclude semantics for logo and change to hint for products on Shrine #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2020
Merged

[Gallery] Exclude semantics for logo and change to hint for products on Shrine #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bda919
Exclude logo from semantics
perclasson Jan 29, 2020
3496982
Use hint instead of onTapHint as it otherwise won't work with VoiceOver
perclasson Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions gallery/gallery/lib/studies/shrine/login.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,18 +85,17 @@ class _ShrineLogo extends StatelessWidget {

@override
Widget build(BuildContext context) {
return Column(
children: [
Image.asset(
'packages/shrine_images/diamond.png',
excludeFromSemantics: true,
),
const SizedBox(height: 16),
Text(
'SHRINE',
style: Theme.of(context).textTheme.headline,
),
],
return ExcludeSemantics(
child: Column(
children: [
Image.asset('packages/shrine_images/diamond.png'),
const SizedBox(height: 16),
Text(
'SHRINE',
style: Theme.of(context).textTheme.headline,
),
],
),
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion gallery/gallery/lib/studies/shrine/supplemental/product_card.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Widget _buildProductCard({
return ScopedModelDescendant<AppStateModel>(
builder: (context, child, model) {
return Semantics(
onTapHint:
hint:
GalleryLocalizations.of(context).shrineScreenReaderProductAddToCart,
child: GestureDetector(
onTap: () {
Expand Down