Adding shrine. #3

RedBrogdon · 2018-06-27T23:39:11Z

No description provided.

willlarche · 2018-06-29T18:11:36Z

shrine/.metadata

@@ -0,0 +1,8 @@
+# This file tracks properties of this Flutter project.


I might be wrong but I think you can drop this file too.

Are you sure? It actually says in the file that it should be version-controlled.

I'm not sure! Could we get more info from the Flutter team proper?

After asking around, it looks like this file stores the ID of the version of the flutter SDK used with the project so that later versions can know which changes to make when someone upgrades.

Cool. Like a kind of lock file. In that case, it might make sense for this repo but not for the codelabs which will def have a requirement to run create.

willlarche · 2018-06-29T18:11:51Z

shrine/README.md

@@ -0,0 +1,45 @@
+# shrine


Shrine with capital S.

willlarche · 2018-06-29T18:12:21Z

shrine/README.md

+[`scoped_model`](https://pub.dartlang.org/packages/scoped_model) to manage the
+state of its shopping cart.
+
+## Goals for this sample


I think you can just say Goals.

True. It's not like I'm going to put my retirement goals in here or anything.

willlarche · 2018-06-29T18:13:23Z

shrine/README.md

@@ -0,0 +1,45 @@
+# shrine
+
+A sample shopping app that uses Material widgets in its UI and


Since this is the first time you say it, could you make it Material Components widgets? I know it doesn't roll off the tongue but I'd want that phrase once in a doc like this.

No problem. Fixed.

willlarche

Can you delete the Android and iOS boilerplate files since flutter create makes them?

Also, I have an icon for the app. See me in email.

willlarche · 2018-07-02T22:58:56Z

shrine/README.md

+
+## Goals
+
+* Show how to customize Flutter's Material Compoenent widgets to produce


Spelling of Component

Nice catch. I think that's the German spelling. :)

Fixed.

willlarche · 2018-07-02T22:59:26Z

shrine/README.md

+
+* Show how to customize Flutter's Material Compoenent widgets to produce
+  a unique design for an app.
+* Show how to use `scoped_model` to manage an app's state and access it


There was a cool video on scoped model architecture for Flutter right? Could you include a link?

I don't think we have anything specifically for scoped_model. There was an I/O talk that showed it as one of a few options, but I think that's about it.

willlarche · 2018-07-02T23:01:27Z

shrine/android/app/build.gradle

@@ -0,0 +1,51 @@
+def localProperties = new Properties()


Can you remove this file?

See comment below.

willlarche · 2018-07-02T23:01:32Z

shrine/android/app/src/main/AndroidManifest.xml

@@ -0,0 +1,39 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"


Can you remove this file?

See comment below.

willlarche · 2018-07-02T23:03:40Z

shrine/ios/Runner/Assets.xcassets/LaunchImage.imageset/README.md

@@ -0,0 +1,5 @@
+# Launch Screen Assets


We can have a launch screen created by the design team too.

I still remember that animated diamond from the mock you showed me. That was really cool.

willlarche · 2018-07-02T23:06:59Z

shrine/lib/app.dart

+import 'colors.dart';
+import 'home.dart';
+import 'login.dart';
+import 'category_menu_page.dart';


Alphabetize.

Ugh. Could have sworn I optimized all the imports. Thanks for catching it.

willlarche · 2018-07-02T23:14:38Z

shrine/lib/backdrop.dart

+import 'package:flutter/material.dart';
+import 'package:meta/meta.dart';
+
+import 'model/product.dart';


willlarche · 2018-07-02T23:15:23Z

shrine/lib/model/app_state_model.dart

+// limitations under the License.
+
+import 'package:scoped_model/scoped_model.dart';
+import 'product.dart';


willlarche · 2018-07-02T23:15:36Z

shrine/lib/model/app_state_model.dart

+import 'product.dart';
+import 'products_repository.dart';
+
+double _shippingCostPerItem = 7.0;


Alphabetize.

RedBrogdon · 2018-07-03T18:08:59Z

Thanks for the review! PTAL.

About the presence of the Android and iOS subprojects, I think this is likely going to be an ongoing difference between your codelab version of Shrine and my example app version of it. The copy here is meant to run out of the box (without anyone running flutter create to make their own project), so it needs those files in place.

willlarche · 2018-07-06T18:19:01Z

shrine/.gitignore

+.pub/
+.idea
+.atom
+.flutter-plugins


Consider .vscode too. Michelle added that one in the codelabs repo.

willlarche · 2018-07-11T20:33:02Z

shrine/ios/Runner/AppDelegate.m

+#include "AppDelegate.h"
+#include "GeneratedPluginRegistrant.h"
+
+@implementation AppDelegate


Glad you're using the ObjC version. Will be lighter!

RedBrogdon · 2018-07-24T20:50:58Z

@willlarche PTAL when you get the chance. I did a giant merge between this and the current state of 104-complete.

willlarche · 2018-07-25T17:20:46Z

jsonexample/lib/built_value/built_complex_object.dart

@@ -23,14 +23,19 @@ abstract class BuiltComplexObject
  @nullable
  double get aDouble;

+  @nullable


Oh, I've literally never noticed this annotation before!

willlarche · 2018-07-25T17:21:35Z

jsonexample/lib/built_value/built_complex_object.g.dart

@@ -7,7 +7,7 @@
 part of 'built_complex_object.dart';



Who generates this?

It's from the built_value package. I've managed to double up some commits in this PR. This is from our JSON example app.

willlarche · 2018-07-25T21:22:41Z

jsonexample/test/widget_tests_test.dart

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'package:flutter/material.dart';


I love that you included tests.

I'll be adding some for Shrine, hopefully, in the near future.

We'll use them too.

willlarche · 2018-07-25T21:39:44Z

shrine/lib/main.dart

+import 'package:flutter/material.dart';
+import 'package:scoped_model/scoped_model.dart';
+
+import 'app.dart';


I think we found you need to package: this import because of a sometimes bug in Dart.

Only in main tho.

I'll double-check. The only package-or-not issue I've run into so far, though, is that if you import a file twice in your app, once with package and once without, Dart will consider them two separate namespaces and double up all the exports.

Here's the issue I've been referencing (if you haven't seen it): dart-lang/sdk#33076.

willlarche · 2018-07-25T21:46:29Z

shrine/lib/model/app_state_model.dart

+      if (_productsInCart[productId] == 1) {
+        _productsInCart.remove(productId);
+      } else {
+        _productsInCart[productId] -= 1;


Might look nice to have -- to match the one above. Or have the one above be +=.

willlarche · 2018-07-25T21:58:00Z

shrine/lib/shopping_cart.dart

+
+class _ShoppingCartPageState extends State<ShoppingCartPage> {
+  List<Widget> _createShoppingCartRows(AppStateModel model) {
+    return model.productsInCart.keys


Indenting of the lines following this doesn't seem quite right but I'm not an expert enough on the style guide to know for sure.

flutter format did it this way, I swear. :)

Adding shrine.

1fe9609

RedBrogdon requested a review from willlarche June 27, 2018 23:39

Cleaning up IDE files.

b89969c

willlarche reviewed Jun 29, 2018

View reviewed changes

RedBrogdon and others added 4 commits June 29, 2018 15:05

Addressing comments.

a39a51f

Adding Travis config for jsonexample. (flutter#4)

d17f968

Adding Travis badge.

d83f650

Updating contributor guidelines.

166c797

willlarche requested changes Jul 2, 2018

View reviewed changes

willlarche reviewed Jul 2, 2018

View reviewed changes

willlarche requested changes Jul 2, 2018

View reviewed changes

Addressing comments.

af463b8

willlarche reviewed Jul 6, 2018

View reviewed changes

willlarche reviewed Jul 11, 2018

View reviewed changes

RedBrogdon and others added 8 commits July 20, 2018 15:18

Adding tests, tweaking built_value code. (flutter#5)

357d172

Adding shrine.

90237a4

Cleaning up IDE files.

a9971d4

Addressing comments.

0bb8eee

Addressing comments.

0944168

Merged changes from MDC codelab 104.

a758fb5

Merging.

513514d

Updating README and .gitignore

241c956

willlarche reviewed Jul 25, 2018

View reviewed changes

willlarche approved these changes Jul 25, 2018

View reviewed changes

Tweaking app state model.

70a1e5a

RedBrogdon merged commit 434a703 into flutter:master Jul 26, 2018

RedBrogdon deleted the shrine branch July 30, 2018 20:38

0xZOne mentioned this pull request Oct 18, 2022

[platform_channels] dependOnInheritedWidgetOfExactType<_ScaffoldMessengerScope>() or dependOnInheritedElement() was called before _PetListScreenState.initState() completed. #1479

Closed

		@@ -0,0 +1,8 @@
		# This file tracks properties of this Flutter project.

		@@ -0,0 +1,45 @@
		# shrine

		A sample shopping app that uses Material widgets in its UI and


		## Goals

		* Show how to customize Flutter's Material Compoenent widgets to produce

		@@ -0,0 +1,39 @@
		<manifest xmlns:android="http://schemas.android.com/apk/res/android"

Adding shrine. #3

Adding shrine. #3

Conversation

RedBrogdon commented Jun 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

willlarche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedBrogdon commented Jul 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedBrogdon commented Jul 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment