Skip to content

[Gallery] Implement Fortnightly study #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 4, 2020
Merged

[Gallery] Implement Fortnightly study #304

merged 13 commits into from
Feb 4, 2020

Conversation

rami-a
Copy link
Contributor

@rami-a rami-a commented Jan 31, 2020 •
edited
Loading

Closes material-components/material-components-flutter-gallery#238

  • Brings in fortnightly study from IO2019 demos in both mobile and desktop layouts
  • Adds support for screen reader and text scaling
  • Updates assets to include higher resolutions

Note: Still waiting on a banner image for it but that will be done in material-components/material-components-flutter-gallery#539

Screen Shot 2020-01-31 at 3 29 47 PM

Screen Shot 2020-01-31 at 3 29 51 PM

Screen Shot 2020-01-31 at 3 30 00 PM

guidezpl
guidezpl approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

Out of curiosity, how big is the fortnightly assets folder?

@rami-a
Copy link
Contributor Author

rami-a commented Feb 3, 2020

Out of curiosity, how big is the fortnightly assets folder?

It is 1.4MB so not too much added.

clocksmith
clocksmith approved these changes Feb 3, 2020
View reviewed changes
gallery/gallery/lib/studies/fortnightly/app.dart
actions: [
IconButton(
icon: const Icon(Icons.search),
tooltip: GalleryLocalizations.of(context).shrineTooltipSearch,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename this to tooltipSearch since its not used by only shrine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool for importing/exporting translations gets confused if these are renamed, so I'm going to keep this as-is for now.

gallery/gallery/lib/studies/fortnightly/shared.dart Outdated
GalleryLocalizations.of(context).craneMinutes(minutes),
style: textTheme.body2,
),
SizedBox(width: 8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing comma

@rami-a rami-a merged commit f8a1229 into flutter:master Feb 4, 2020
@rami-a rami-a deleted the fortnightly branch February 4, 2020 14:57
@0xZOne 0xZOne mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clocksmith clocksmith clocksmith approved these changes

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Fortnightly Study (8)
3 participants
@rami-a @clocksmith @guidezpl