add web_dashboard sample #306
Conversation
| @@ -0,0 +1,17 @@ | |||
| # web_dashboard | |||
There was a problem hiding this comment.
nit: It'd be a good idea to add a couple sentences:
- Explain that this is an in-progress sample.
- Point out that it's just for the web, and shouldn't be built for Android/iOS/desktop.
You can also link from here to the README in /experimental, which will tell people about the need to use the master channel.
|
|
||
| import 'src/adaptive_scaffold.dart'; | ||
|
|
||
| /// The [Key] for the inner [Navigator] |
There was a problem hiding this comment.
nit: Period at the end of the comments (here and below).
| Widget build(BuildContext context) { | ||
| return MaterialApp( | ||
| // Forward the initial route to the app shell. | ||
| onGenerateInitialRoutes: (initialRoute){ |
There was a problem hiding this comment.
nit: space between the closing paren and the opening brace.
Related: Nothing in /experimental gets touched by CI, so formatting and analysis aren't checked automatically. I have an alias I use a lot that does both, in case it's of use to you:
alias fa='find . | grep "\.dart$" | xargs flutter format && flutter analyze'
| // initial build phase. Right now this is being called in the wrong | ||
| // order. (Refreshing the browser with the initial route set to | ||
| // '/settings' invokes onGenerateRoute with '/' instead of | ||
| // '/settings'. |
| }, | ||
| ), | ||
| currentIndex: _currentIndex, | ||
| destinations: [ |
There was a problem hiding this comment.
nit: Can this be a const list?
| } | ||
|
|
||
| /// A widget that adapts to the current display size, displaying a [Drawer], | ||
| /// [NavigationRail], or [BottomAppBar]. Navigation destinations are defined in |
There was a problem hiding this comment.
nit: BottomNavigationBar rather than BottomAppBar?
| return Scaffold( | ||
| appBar: AppBar(title: widget.title,), | ||
| body: Row( | ||
| children: <Widget>[ |
There was a problem hiding this comment.
nitL: No type specifier necessary here.
| var navState = _navigatorKey.currentState as NavigatorState; | ||
| navState.pushNamed(_routeForIndex(idx)); | ||
| }, | ||
| floatingActionButton: FloatingActionButton( |
There was a problem hiding this comment.
I can imagine wanting this button to have different effects based on which page is loaded into the navigator inside the AdaptiveScaffold. Is that something that would be supported?
There was a problem hiding this comment.
I don't think the AdaptiveScaffold would cover that case. The user would be responsible for applying any effects (or hiding the FAB altogether) based on the currentIndex.
|
closing in favor of #333, which moves this into an experiments/ directory |
This adds a responsive master-detail app with browser URL navigation. The app combines a new
AdaptiveScaffoldwidget that switches between aDrawer,NavigationRail, andBottomAppBarfor navigation. The body of theScaffoldis aNavigatorthat handles three routes usingonGenerateRoute. The URL stays in sync with the routing in the app.Right now, there are two Navigators, the root Navigator and the child Navigator. The root Navigator forwards the initial route to the child using
onGenerateInitialRoutesand passing theRouteSettings. TheAppShellwidget's keeps the AdaptiveScaffold Navigator in sync.