[Gallery] Update desktop Rally for pages that did not have designs before #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clocksmith
approved these changes
Feb 5, 2020
perclasson
force-pushed
the
new_screens_rally
branch
from
874a5bc to
82056b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These screens lacked designs for desktop previously. I asked the designer for what do add here and basically we want to display more data as the screen grows. Thus what changed:
Closes material-components/material-components-flutter-gallery#90
Closes material-components/material-components-flutter-gallery#540
Note that this review is dependent on #312 being merged.
Screenshots
I verified that it looks good with large text scale as well as RTL but did not add those screenshots here.