Skip to content

[Gallery] Bring in Fortnightly banner #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2020
Merged

[Gallery] Bring in Fortnightly banner #317

merged 3 commits into from
Feb 6, 2020

Conversation

rami-a
Copy link
Contributor

@rami-a rami-a commented Feb 5, 2020

Also update the description text

Closes material-components/material-components-flutter-gallery#539

Screen Shot 2020-02-05 at 5 06 26 PM

johnsonmh
johnsonmh approved these changes Feb 5, 2020
View reviewed changes
Copy link

@johnsonmh johnsonmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

@guidezpl
Copy link
Member

guidezpl commented Feb 6, 2020 •
edited
Loading

Simulator Screen Shot - iPad Pro (12 9-inch) (3rd generation) - 2020-02-06 at 10 46 45
Can you update the scroll indicator for light mode to be more visible (keeping the arrow white, like in dark mode would work)?

@rami-a
Copy link
Contributor Author

rami-a commented Feb 6, 2020

Good catch @guidezpl , fixed!

@rami-a rami-a merged commit 96dc898 into flutter:master Feb 6, 2020
@rami-a rami-a deleted the fortnightly-banner branch February 6, 2020 15:22
@0xZOne 0xZOne mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonmh johnsonmh johnsonmh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add banner image for Fortnightly (0.5)
3 participants
@rami-a @guidezpl @johnsonmh