[Gallery] Implement Crane middle front layer #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidezpl
changed the title
perclasson
approved these changes
Feb 6, 2020
I tried something like that and it felt less readable so I'm going to leave it as is for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the expected design for Crane's middle front layer being higher than the others. I opted not to create recreate custom version of existing Material widgets, instead using an OverflowBox. The only downside is there is a small portion of the middle tab that cannot be interacted with (see below in red). Since everything else remains functional, I think this is acceptable
Closes material-components/material-components-flutter-gallery#133