Skip to content

Fix - text on MaterialButton not changing #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

yuhamadan
Copy link
Contributor

text on MaterialButton was not changing from 'Write Essay' to 'Delete Essay' and vice versa because setState was never called

text on MaterialButton was not changing from 'Write Essay' to 'Delete Essay' and vice versa because setState was never called
@yuhamadan yuhamadan requested a review from johnpryan February 12, 2020 07:35
@RedBrogdon
Copy link
Contributor

Thanks for submitting a pull request, @yuhamadan!

It looks like our automated tests are failing due to a formatting issue with the code you've added. Try running flutter format on the file you changed. That should fix the issue.

did not think about formatting as I was editing the file directly on Github
@yuhamadan
Copy link
Contributor Author

Thanks for the info @RedBrogdon
I edited the file directly on Github and forgot about code formatting :)
I hope its fixed now.

@RedBrogdon RedBrogdon requested review from RedBrogdon and removed request for johnpryan February 21, 2020 16:36
Copy link
Contributor

@RedBrogdon RedBrogdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to land. Thanks, @yuhamadan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants