Skip to content

Update impeller documentation to include the decision that android impeller requires api XX and higher #11887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reidbaker opened this issue Apr 9, 2025 · 5 comments
Closed

Update impeller documentation to include the decision that android impeller requires api XX and higher #11887

reidbaker opened this issue Apr 9, 2025 · 5 comments
Assignees
@jmagman
Labels
e0-minutes Effort: < 60 min p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@reidbaker
Copy link
Contributor

reidbaker commented Apr 9, 2025 •
edited by jmagman
Loading

Update the documentation https://docs.flutter.dev/perf/impeller#android to include the relevant public pieces of go/android-impeller-strategy

Filing this as a flutter/flutter issue so it gets picked up in engine triage.

@ engine team if you think this should instead be done by the android team reassign this to team-android and we will pick it up.
@jmagman
Copy link
Member

jmagman commented Apr 9, 2025

https://docs.flutter.dev updates are tracked in flutter/website, I'll transfer this over there.

@jmagman jmagman transferred this issue from flutter/flutter Apr 9, 2025
@jmagman
Copy link
Member

jmagman commented Apr 9, 2025

Filing this as a flutter/flutter issue so it gets picked up in engine triage.

Sorry I stepped on this by transferring. @jonahwilliams want to pick this up? Or should we work with @sfshaza2 to make sure it's updated?

@jmagman jmagman mentioned this issue Apr 9, 2025
Merged
4 tasks
@sfshaza2
Copy link
Contributor

sfshaza2 commented Apr 9, 2025

Yes, I asked @jonahwilliams about this yesterday. But I'm fine with your PR, @jmagman!

@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e0-minutes Effort: < 60 min labels Apr 9, 2025
@jmagman jmagman self-assigned this Apr 9, 2025
@jonahwilliams
Copy link
Member

Sorry, I have a lot on my plate so I hadn't gotten to it yet, but thanks for the PR @jmagman !

sfshaza2 pushed a commit that referenced this issue Apr 10, 2025
@jmagman
Document Impeller is unavailable on < Android API 29 (#11888)
2cedb60 
_Description of what this PR is changing or adding, and why:_
Update the documentation https://docs.flutter.dev/perf/impeller to note
Impeller is unavailable on < Android API 29

_Issues fixed by this PR (if any):_
#11887

_PRs or commits this PR depends on (if any):_ None

## Presubmit checklist

- [x] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
@sfshaza2 sfshaza2 changed the title Update impeller documentation to include the decision that android impeller will api XX and higher Update impeller documentation to include the decision that android impeller requires api XX and higher Apr 10, 2025
@sfshaza2
Copy link
Contributor

Fixed in PR #11888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmagman jmagman

Labels
e0-minutes Effort: < 60 min p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmagman @reidbaker @jonahwilliams @sfshaza2