Skip to content

Implement an initial dark mode #11877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 10, 2025
Merged

Implement an initial dark mode #11877

merged 22 commits into from
Apr 10, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Apr 6, 2025

Resolves #3632

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Apr 6, 2025

Visit the preview URL for this PR (updated for commit 0766125):

https://flutter-docs-prod--pr11877-feat-dark-mode-toggle-tcfsaj35.web.app

@parlough parlough changed the title Add toggle to dark mode [Do not merge] Add toggle to dark mode Apr 7, 2025
@parlough parlough marked this pull request as ready for review April 7, 2025 17:33
@parlough parlough requested review from sfshaza2, antfitch and a team as code owners April 7, 2025 17:33
@parlough parlough changed the title [Do not merge] Add toggle to dark mode [Do not merge] Implement an initial dark mode Apr 7, 2025
@lamek
Copy link

lamek commented Apr 7, 2025

This looks great. I checked about 50 pages and focused on as many UI elements as I could list. The only thing that stuck out was images. Here's one example where the background going dark makes it very hard to see the : https://flutter-docs-prod--pr11877-feat-dark-mode-toggle-tcfsaj35.web.app/ui/layout#conceptual-example

I made a list of .md files that include an image reference: https://gist.github.com/lamek/0d635c930d29f4fbc72e628e93e8e14b

A lot to check. Alternatively, just scanning the images dir for a file count:

86 directories, 879 files
lamenzo@penguin:~/website/src/content/assets/images/docs$

But, I wouldn't consider checking every file a blocker. IMO, spot checking ~50 images, only 1 had an issue.

I think it might be best to tackle this over time, and add some quick guidance when adding an image to preview in both dark/light mode.

@lamek
Copy link

lamek commented Apr 7, 2025

"Regular" DartPad has a dark mode. Do you know if it's possible to toggle embedded DartPad to dark mode?

Example page: https://flutter-docs-prod--pr11877-feat-dark-mode-toggle-tcfsaj35.web.app/cookbook/lists/floating-app-bar

Copy link
Contributor

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gorgeous!!!

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your thorough review, @lamek! We discussed many of these issues in our 1-1-1 meeting today. :) As I stated in the meeting, I feel that this is good enough to land! lgtm

@parlough parlough changed the title [Do not merge] Implement an initial dark mode Implement an initial dark mode Apr 10, 2025
@parlough parlough merged commit e228406 into main Apr 10, 2025
9 checks passed
@parlough parlough deleted the feat/dark-mode-toggle branch April 10, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode to the official documentation
5 participants