Rework of "Lay out a widget" + use of code-excerpts #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chalin
force-pushed
the
chalin-layout-a-widget-0117
branch
2 times, most recently
from
4f1ab0c to
ee93f9b
Compare
chalin
commented
Jan 17, 2019
| @@ -72,170 +72,158 @@ the children should occupy. | |||
|
|
|||
| ## Lay out a widget | |||
|
|
|||
| {{site.alert.secondary}} | |||
| <h4 class="no_toc">What's the point?</h4> | |||
There was a problem hiding this comment.
@sfshaza2 - I dropped the "What's the point" alert for this section. Most points didn't seem that helpful, except for one -- concerning Scaffold -- which I moved into the main text because it wasn't even discussed there. WDYT?
chalin
force-pushed
the
chalin-layout-a-widget-0117
branch
3 times, most recently
from
75dc0b2 to
12d08c7
Compare
chalin
force-pushed
the
chalin-layout-a-widget-0117
branch
from
12d08c7 to
1ea7fdf
Compare
Contributes to #2233
chalin
force-pushed
the
chalin-layout-a-widget-0117
branch
from
1ea7fdf to
2232e5c
Compare
sfshaza2
approved these changes
Jan 22, 2019
We discussed this offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the reworked "Lay out a widget" section only. Note that I changed the numbered list to section headings. I did this because the numbered list just didn't work anymore: item 4 was a page and a half long. At that length readers lose the context of the numbered list.
Contributes to #2233
https://flutter-io-staging-2.firebaseapp.com/docs/development/ui/layout#lay-out-a-widget