Update firebase.json #7192
Merged
Update firebase.json #7192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
requested review from
sfshaza2,
khanhnwin,
domesticmouse and
johnpryan
as code owners
cyanglaz
reviewed
May 25, 2022
firebase.json
Outdated
| @@ -301,6 +301,7 @@ | |||
| { "source": "/go/platform-based-key-events", "destination": "https://docs.google.com/document/d/1FDuxxEh810XpY561SgeiyUR0gU2eVz5kRpCFI55ibec/edit", "type": 301 }, | |||
| { "source": "/go/platform-channels-in-federated-plugins", "destination": "https://docs.google.com/document/d/1BSrDA_FjLU-3T0H774RocJ4IYyc0ytMl937rAimGJdg/edit?usp=sharing", "type": 301 }, | |||
| { "source": "/go/platform-interface-breaking-changes", "destination": "https://docs.google.com/document/d/1LD7QjmzJZLCopUrFAAE98wOUQpjmguyGTN2wd_89Srs/edit#heading=h.xabf9lffxrkb", "type": 301 }, | |||
| { "source": "/go/platform-view-focus", "destination": "https://docs.google.com/document/d/1GG8VfYeuVtTQHiMWQXbrSG5HEUorzqU8IGbNySVJ-bY/edit", "type": 301 }, | |||
There was a problem hiding this comment.
maybe add "ios"?
go/ios-platform-view-focus
Also, not sure if it matters, do you know what the /edit postfix does?
There was a problem hiding this comment.
or go/flutter-ios-platform-view-focus
jmagman
approved these changes
May 25, 2022
Co-authored-by: Jenn Magder <[email protected]>
jmagman
reviewed
May 25, 2022
Co-authored-by: Jenn Magder <[email protected]>
domesticmouse
approved these changes
May 25, 2022
hellohuanlin
added
the
act.await-dev-pr
|
Once @jmagman's edits are incorporated, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to add platform view focus doc
https://docs.google.com/document/d/1GG8VfYeuVtTQHiMWQXbrSG5HEUorzqU8IGbNySVJ-bY/edit
Issues fixed by this PR (if any):
flutter/flutter#34187
Presubmit checklist