Skip to content

Add Scrolling intro page #9068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 21, 2023
Merged

Add Scrolling intro page #9068

merged 10 commits into from
Jul 21, 2023

Conversation

sfshaza2
Copy link
Contributor

@sfshaza2 sfshaza2 commented Jul 19, 2023 •
edited
Loading

This removes the Slivers page from the Advanced UI section into its own Scrolling section. We will also be adding scrolling recipes to the sidebar of this section.

The intro page kind of grew to be longer than I planned...

This also adds a tooling error to the common errors page.

Fixes #9064

cc @Piinks @parlough

@sfshaza2 sfshaza2 added the review.tech Awaiting Technical Review label Jul 19, 2023
Piinks
Piinks approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you!

@Piinks
Copy link
Contributor

Piinks commented Jul 19, 2023

Related issues for this:

@sfshaza2 sfshaza2 added review.copy Awaiting Copy Review and removed review.tech Awaiting Technical Review labels Jul 20, 2023
@sfshaza2
Copy link
Contributor Author

@parlough, I don't see an auto-staged site listed?

parlough
parlough reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks great to me!

I left a few comments on the sidenav, including a fix for the build.

Can you also add a redirect for the old slivers location:

{ "source": "/ui/advanced/slivers", "destination": "/ui/scrolling/slivers", "type": 301 },

@sfshaza2 sfshaza2 requested a review from khanhnwin as a code owner July 20, 2023 17:51
parlough
parlough approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after a few comments are addressed:

@parlough parlough added the review.await-update Awaiting Updates after Edits label Jul 20, 2023
@sfshaza2 sfshaza2 removed the review.copy Awaiting Copy Review label Jul 21, 2023
@sfshaza2 sfshaza2 removed the review.await-update Awaiting Updates after Edits label Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 402cc44):

https://flutter-docs-prod--pr9068-scrolling-rofulqrf.web.app

(expires Fri, 04 Aug 2023 17:23:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

parlough
parlough reviewed Jul 21, 2023
View reviewed changes
@parlough parlough added the st.RFM Ready to merge or land label Jul 21, 2023
@sfshaza2 sfshaza2 removed the st.RFM Ready to merge or land label Jul 21, 2023
@sfshaza2 sfshaza2 merged commit 5af38d4 into main Jul 21, 2023
@sfshaza2 sfshaza2 deleted the scrolling branch July 21, 2023 18:05
@parlough
Copy link
Member

Woooo! Thanks @sfshaza2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@Piinks Piinks Piinks approved these changes

@atsansone atsansone Awaiting requested review from atsansone

@khanhnwin khanhnwin Awaiting requested review from khanhnwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an intro page for scrolling
3 participants
@sfshaza2 @Piinks @parlough