Skip to content

Fix migration guide for "deprecated gradle plugin apply" #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Fix migration guide for "deprecated gradle plugin apply" #9907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e276ab3
fix missing entry in Index
bartekpacia Dec 8, 2023
88b4073
fix {agpVersion} and {kotlinVersion} not displaying
bartekpacia Dec 8, 2023
4da5d74
add redirect for `flutter-gradle-plugin-apply`
bartekpacia Dec 8, 2023
5ffdd76
fix link in index
bartekpacia Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@
{ "source": "/go/flutter-engine-clocks", "destination": "https://docs.google.com/document/d/1Sx8QA1qXgJGw5r4ESviDnU2LSShNHiq_LjbRWPgSvXQ/edit?usp=sharing&resourcekey=0-BoBvLxgqf_nc_rwLc0zmTw", "type": 301 },
{ "source": "/go/flutter-engine-extensions", "destination": "https://docs.google.com/document/d/1xG7jR4FserdW7TdwnklF3_lXUGmt4myPQjDGF3LFtCQ/edit?resourcekey=0-Iug4D2mWuyQI6suvC_2itw#", "type": 301 },
{ "source": "/go/flutter-for-embedded-linux", "destination": "https://docs.google.com/document/d/1n4NXCk0QlGz16gUCtywR79H0Z1fzPqB2iNL8oxuexuk/edit?usp=sharing", "type": 301 },
{ "source": "/go/flutter-gradle-plugin-apply", "destination": "/release/breaking-changes/flutter-gradle-plugin-apply", "type": 301 },
{ "source": "/go/flutter-iap-migrate-pblv2", "destination": "https://docs.google.com/document/d/1XM16UsLE_aPWoZnheE9waO06mhxLkkWjpPf9jtI1AdY/edit", "type": 301 },
{ "source": "/go/flutter-ios-system-font", "destination": "https://docs.google.com/document/d/1FG9ONkG-sLuFkb9vUAL2i7oeUtUqm8qiQJe_poK754w/edit", "type": 301 },
{ "source": "/go/flutter-lints", "destination": "https://docs.google.com/document/d/1b0X0HOzvFY3WxI363U8BXx6Am13qFm96KlbS72mmFAk/edit", "type": 301 },
Expand Down
15 changes: 7 additions & 8 deletions src/release/breaking-changes/flutter-gradle-plugin-apply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ buildscripts.
### android/settings.gradle

Replace the contents of `<app-src>/android/settings.gradle` with the below,
remembering to replace `{{agpVersion}}` and `{{kotlinVersion}}` with previously
remembering to replace `{agpVersion}` and `{kotlinVersion}` with previously
used values:

```gradle
Expand All @@ -58,8 +58,8 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "{{agpVersion}}" apply false
id "org.jetbrains.kotlin.android" version "{{kotlinVersion}}" apply false
id "com.android.application" version "{agpVersion}" apply false
id "org.jetbrains.kotlin.android" version "{kotlinVersion}" apply false
}

include ":app"
Expand All @@ -75,7 +75,7 @@ Remove the whole `buildscript` block from `<app-src/android/build.gradle`:

```diff
-buildscript {
- ext.kotlin_version = '{{kotlinVersion}}'
- ext.kotlin_version = '{kotlinVersion}'
- repositories {
- google()
- mavenCentral()
Expand Down Expand Up @@ -176,15 +176,14 @@ the following lines to `<app-src>/android/settings.gradle`:
```diff
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "{{agpVersion}}" apply false
id "org.jetbrains.kotlin.android" version "{{kotlinVersion}}" apply false
id "com.android.application" version "{agpVersion}" apply false
id "org.jetbrains.kotlin.android" version "{kotlinVersion}" apply false
+ id "com.google.gms.google-services" version "4.4.0" apply false
+ id "com.google.firebase.crashlytics" version "2.9.9" apply false
}
```

and the following lines to `<app-src>/android/app/build.gradle` (remembering to
replace `{{agpVersion}}` and `{{kotlinVersion}}` with previously used values):
and the following lines to `<app-src>/android/app/build.gradle`:

```diff
plugins {
Expand Down
3 changes: 2 additions & 1 deletion src/release/breaking-changes/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,13 @@ release, and listed in alphabetical order:
* [Deprecate `TextField.canRequestFocus`][]
* [Accessibility traversal order of tooltip changed][]
* [Default multitouch scrolling][]
* [Deprecate imperative apply of Flutter's Gradle plugins][]

[Migrate RawKeyEvent/RawKeyboard system to KeyEvent/HardwareKeyboard system]: {{site.url}}/release/breaking-changes/key-event-migration
[Deprecate `TextField.canRequestFocus`]: {{site.url}}/release/breaking-changes/can-request-focus
[Accessibility traversal order of tooltip changed]: {{site.url}}/release/breaking-changes/tooltip-semantics-order
[Default multitouch scrolling]: {{site.url}}/release/breaking-changes/multi-touch-scrolling
[Deprecate imperative apply of Flutter's Gradle plugins]: ${{ site.url }}/release/breaking-changes/flutter-gradle-plugin-apply
[Deprecate imperative apply of Flutter's Gradle plugins]: {{site.url}}/release/breaking-changes/flutter-gradle-plugin-apply

### Released in Flutter 3.16

Expand Down