Skip to content

chore: Move very_good_analysis to dev_dependencies #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2022
Merged

chore: Move very_good_analysis to dev_dependencies #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38af23e
chore: remove unused dependency
JCQuintas May 17, 2022
b61fc2a
Update pubspec.yaml
JCQuintas May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ dependencies:
provider: ^6.0.1
video_player: ^2.2.7
wakelock: ^0.6.1+1
very_good_analysis: ^2.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to dev_dependencies instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not used. Having it or not doesn't make any difference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can notice that because there is no entry on the pubspec.lock

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still though, if we decide to increase the analysis options in the future, we want to be able to pull lint rules from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then you are still able to add it when it is decided you want to use it?

If you really want it to be there even though it is not used I can add it, but it sounds a bit of a waste. I wouldn't recommend on installing libraries just in case it might be used in the future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a long list of housekeeping items that I will get to in the near future. Analysis is one of them. Just need to carve out the time for that very soon.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there's no harm in leaving something in dev_dependencies that will never get exposed to end users, even if not really used yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No harm, but it can cause confusion. I've moved it to dev_dependencies

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @JCQuintas. Adding a dependency which is not used makes no sense and confuse other developers.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use very_good_analysis later than add it when you need it. I see no advantage in adding a dependency which is not used.


dev_dependencies:
flutter_test:
sdk: flutter
lint: ^1.7.2
very_good_analysis: ^2.4.0

flutter:
uses-material-design: true