Skip to content

Conversation

diegotori
Copy link
Collaborator

Raised the minimum supported Flutter version to 3.29.

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 44.09091% with 123 lines in your changes missing coverage. Please review.

Project coverage is 44.91%. Comparing base (fbb60cb) to head (e176704).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/cupertino/cupertino_controls.dart 39.70% 41 Missing ⚠️
lib/src/progress_bar.dart 3.03% 32 Missing ⚠️
lib/src/material/material_controls.dart 45.94% 20 Missing ⚠️
lib/src/material/material_desktop_controls.dart 55.88% 15 Missing ⚠️
...rc/cupertino/widgets/cupertino_options_dialog.dart 0.00% 6 Missing ⚠️
lib/src/material/widgets/options_dialog.dart 0.00% 3 Missing ⚠️
lib/src/models/subtitle_model.dart 0.00% 3 Missing ⚠️
lib/src/center_play_button.dart 80.00% 1 Missing ⚠️
lib/src/chewie_player.dart 66.66% 1 Missing ⚠️
...ib/src/material/widgets/playback_speed_dialog.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   44.55%   44.91%   +0.36%     
==========================================
  Files          22       21       -1     
  Lines        1560     1574      +14     
==========================================
+ Hits          695      707      +12     
- Misses        865      867       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegotori diegotori merged commit ad2e289 into fluttercommunity:master Jun 30, 2025
2 checks passed
@diegotori diegotori deleted the flutter_3.29_minimum branch June 30, 2025 15:39
diegotori added a commit that referenced this pull request Jun 30, 2025
lg8294 added a commit to lg8294/chewie that referenced this pull request Aug 5, 2025
* commit '1369e9de5480063239626ddd11752b32230ee8e9':
  chewie, version 1.12.0. Fixes issue fluttercommunity#923.
  Added more fixes to the Github workflow.
  Added more fixes related to supporting Flutter 3.29.
  Raised the minimum supported Flutter version to 3.29.

# Conflicts:
#	.gitignore
#	lib/src/player_with_controls.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant