Skip to content

Conversation

MisterJimson
Copy link
Contributor

@MisterJimson MisterJimson commented Oct 16, 2020

Description

Fix running Android example in package_info_plus.

Related Issues

Without this change, running the example on Android results in: flutter/flutter#51195

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran merged commit e5dd7df into fluttercommunity:main Oct 19, 2020
@miquelbeltran
Copy link
Member

Thanks @MisterJimson do you know if this issue is also present on other packages?

@MisterJimson
Copy link
Contributor Author

@miquelbeltran Ill try them out and open PRs if so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants