Skip to content

fix(share_plus): Another try at fixing url encoding #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2021

Conversation

ueman
Copy link
Contributor

@ueman ueman commented May 14, 2021

Description

See #236 (comment)

cc @miquelbeltran @stuartmorgan

Related Issues

No, but this comment: #236 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily mhadaily requested review from miquelbeltran and jpnurmi May 14, 2021 18:32
@miquelbeltran
Copy link
Member

Alright, thanks for taking care of this! I will do the releases as well and then merge.

@miquelbeltran
Copy link
Member

packages are released, I will merge this tomorrow, can't stay up until late waiting for CI to finish :)

@miquelbeltran miquelbeltran merged commit d0ffef6 into fluttercommunity:main May 14, 2021
@miquelbeltran
Copy link
Member

you know what, it doesn't matter, is just the format job that takes forever 😂

@ueman ueman deleted the fix/url-encoding-again branch May 14, 2021 20:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants