-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Linux Support to Battery Plus #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3bc197
to
69c3203
Compare
slightfoot
pushed a commit
that referenced
this pull request
Oct 2, 2020
* setup pedantic * lint fix with pedantic 1.9.0 Co-authored-by: Miquel Beltran <[email protected]>
69c3203
to
71cba3d
Compare
run it on my machine and worked as expected 👍 |
aee220d
to
43129c2
Compare
Rebased and resolved conflicts after merging #2 for macOS |
8cc6fab
to
4f11466
Compare
hi! whats stopping us from merging this one? |
jpnurmi
reviewed
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi! whats stopping us from merging this one?
This will be merged soon. :) We have just reviewed the code with @mhadaily.
4f11466
to
c1ad0ef
Compare
jpnurmi
added a commit
to jpnurmi/plus_plugins
that referenced
this pull request
Dec 13, 2020
jpnurmi
added a commit
to jpnurmi/plus_plugins
that referenced
this pull request
Dec 13, 2020
jpnurmi
added a commit
to jpnurmi/plus_plugins
that referenced
this pull request
Dec 13, 2020
jpnurmi
added a commit
to jpnurmi/plus_plugins
that referenced
this pull request
Dec 13, 2020
Closed
7 tasks
7 tasks
8 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from here https://github.com/fluttercommunity/battery_plus/pull/5