Skip to content

Conversation

StanleyCocos
Copy link
Contributor

@StanleyCocos StanleyCocos commented Sep 4, 2025

Description

This PR makes some adjustments.

targetSdk: 34 -> 36
compileSdk: 34 -> 36
gradle: 8.3.1 -> 8.6.0
kotlin: 1.7.22 -> 1.9.23
ndk: 27.0.12077973

The currently submitted PR can no longer pass the Android-side tests. I believe the relevant dependencies should be upgraded to allow the tests to run smoothly.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@StanleyCocos StanleyCocos changed the title feat: android dependency upgrade feat(All): android dependency upgrade Sep 4, 2025
@StanleyCocos StanleyCocos changed the title feat(All): android dependency upgrade feat(all): android dependency upgrade Sep 4, 2025
@StanleyCocos
Copy link
Contributor Author

@vbuberen
Sorry, I saw that you have a task to upgrade to SDK 36, but I recently submitted a PR that can no longer pass the Android tests because of my submission. This may conflict with your plan. Please check if the current PR needs to be closed.

@StanleyCocos
Copy link
Contributor Author

@vbuberen
It seems there are many issues, and I’m not sure whether to continue.

@vbuberen
Copy link
Collaborator

vbuberen commented Sep 4, 2025

Hi. Thanks for your draft PR, but it is something I am currently working on, but had no time to finish and open PRs properly. I would like to finish it myself as I have a bit different approach, since decided to use things like compileSDK from Flutter env variables. Additionally, my first of PRs that I started for android_alarm_manager_plus a few weeks ago had a bit different versions for Gradle, Kotlin, etc.
There will be PRs in next few days since I am finally back from recent travel and will have time to release all the changes for Android part of plugins. I am targeting early next week to release updates for all plugins.

With that being said, I will close this PR.

@vbuberen vbuberen closed this Sep 4, 2025
@StanleyCocos StanleyCocos deleted the fix/android_dependency_upgrade branch September 5, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants