refactor: eliminate hidden mutations in HelmRepository client opts #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hidden mutation functions with explicit configuration pattern to eliminate side effects where ClientOpts was modified through configuration functions. Adds CertsTempDir field to ClientOpts struct. Signed-off-by: cappyzawa <[email protected]>
cappyzawa
force-pushed
the
refactor/helm-repository-client-opts-option-pattern
branch
from
8f8ad70 to
df06de9
Compare
cappyzawa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors HelmRepository client options generation to use explicit configuration pattern. The previous implementation had hidden mutable side effects where
ClientOptswas modified through configuration functions, making the code harder to reason about.Changes
CertsTempDirfield toClientOptsand updateGetClientOptssignature to return(*ClientOpts, error)instead of(*ClientOpts, string, error)clientOpts.CertsTempDirRelated
Addresses similar error message clarity issues identified in #1852 (comment)