Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

Update extension.neon #5

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Update extension.neon #5

merged 2 commits into from
Apr 27, 2021

Conversation

convenient
Copy link
Contributor

Fix phpstan.neon to work with latest phpstan

⚠️  You're using a deprecated config option autoload_files. ⚠️️
You might not need it anymore - try removing it from your
configuration file and run PHPStan again.
If the analysis fails, there are now two distinct options
to choose from to replace autoload_files:
1) scanFiles - PHPStan will scan those for classes and functions
   definitions. PHPStan will not execute those files.
2) bootstrapFiles - PHPStan will execute these files to prepare
   the PHP runtime environment for the analysis.
Read more about this in PHPStan's documentation:
https://phpstan.org/user-guide/discovering-symbols

Fix phpstan.neon to work with latest phpstan

```
⚠️  You're using a deprecated config option autoload_files. ⚠️️
You might not need it anymore - try removing it from your
configuration file and run PHPStan again.
If the analysis fails, there are now two distinct options
to choose from to replace autoload_files:
1) scanFiles - PHPStan will scan those for classes and functions
   definitions. PHPStan will not execute those files.
2) bootstrapFiles - PHPStan will execute these files to prepare
   the PHP runtime environment for the analysis.
Read more about this in PHPStan's documentation:
https://phpstan.org/user-guide/discovering-symbols
```
@convenient
Copy link
Contributor Author

hello @fooman

I am just wondering if you are able to have a look at this some point? Or is it best to look at an alternative/fork it?

Thanks

@fooman
Copy link
Owner

fooman commented Apr 26, 2021

@convenient thanks for the ping. Happy to go ahead with merging this and tag a new version. Do you mind confirming if https://github.com/fooman/phpstan-magento2-magic-methods/blob/master/composer.json#L13 needs bumping up as well?

bitExpert/phpstan-magento#40 (comment)

> Seems like the autoload_files option got deprecated with PHPStan 0.12.26. Removing autoload_files won't work as the file contains the logic to register the custom autoloaders
@convenient
Copy link
Contributor Author

@fooman bitExpert/phpstan-magento#40 (comment)

Seems like the autoload_files option got deprecated with PHPStan 0.12.26. Removing autoload_files won't work as the file contains the logic to register the custom autoloaders

Updated composer.json to require 0.12.26 and above 👍

@fooman fooman merged commit 6353941 into fooman:master Apr 27, 2021
@fooman
Copy link
Owner

fooman commented Apr 27, 2021

Thanks Luke

@convenient convenient deleted the patch-1 branch April 28, 2021 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants