-
Notifications
You must be signed in to change notification settings - Fork 68
add CI for publishing on the fortran-lang twitter account upon merging a certain PR #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Amazing, great work @p-costa! I'll have a look through this later today. |
forgot to remove this line I used for debugging
Great work. I tested it a bit. Here are my questions: https://github.com/p-costa/piu-piu-sandbox/pull/1#issuecomment-703616971 |
Thanks for creating the PR and testing it @certik . I should have mentioned here as well that: #tweet
#untweet will remove the tweet. |
so that the tweet keyword is not found in other closed pull requests
Thanks, @p-costa! I have 2 questions:
|
Hi @milancurcic ,
edit: I realize did not fully answer your question: if one merges with a tweet a message with > 280 characters anyway, the |
, because single quotes are more common in sentences; then one can use escape characters to print double quotes in tweets (if something goes wrong it will appear in the preview)"
I converted this to draft so that I can polish the implementation tomorrow and make some final tests. Feel free to review it in any case, as it should not change much from my side. |
Just want to comment here that it's ready. But no rush from my side -- I understand that this being a small convenience shouldn't be a high priority thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I don't see any issues with the workflow which has already been tested and demonstrated. Clearly some work is still required to link to the twitter account.
It looks like anyone can create and modify a tweet, but only maintainers can merge and publish the tweet so I think this workflow works well. Thanks @p-costa 👍
+1 with me also
…On Fri, Oct 9, 2020, at 3:08 AM, Laurence Kedward wrote:
***@***.**** approved this pull request.
Great stuff! I don't see any issues with the workflow which has already
been tested and demonstrated. Clearly some work is still required to
link to the twitter account.
It looks like anyone can create and modify a tweet, but only
maintainers can merge and publish the tweet so I think this workflow
works well. Thanks @p-costa <https://github.com/p-costa> 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#147 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWCPBVYHG75UIKRBAQLSJ3HJHANCNFSM4SESIBIA>.
|
It looks like the homework for me is to set up the app and keys:
I think I'll be able to do it today, if not, then over the weekend. |
Okay, this is now done. I set the secrets in the Org and allowed them to be shared with this repo. This way we can easily reuse them in other repos when we want. Should this now be merged? |
Hello everyone!
As discussed in the fortran-lang discourse, this PR implements a CI that:
Please have a look, and feel free to test it by submitting a PR in this repo I created: p-costa/piu-piu-sandbox.
If you are happy with it, to get it to work, one needs to create a twitter app, following the steps similar to those indicated here: github.com/gr2m/twitter-together/blob/master/docs/01-create-twitter-app.md and add the corresponding keys and tokens to this repo.
I should thank the author of find-comment for very promptly considering issues #23 and #24.
The tweets are published using send-tweet-action, as per @LKedward suggestion.
It works as follows:
A comment in the PR starting with the keyword #tweet
text
will:A comment in the PR starting with the keyword #untweet will remove the tweet.
Then, when the PR is merged, the CI will look for a specific keyword ([tweet]) published by the GitHub actions bot, and, if it exists in the PR comment thread, it will be deployed for publication in the fortran-lang twitter account.