Skip to content

add Cantera #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add Cantera #58

wants to merge 1 commit into from

Conversation

mefuller
Copy link

@mefuller mefuller commented Oct 9, 2021

Add Cantera to index (chemical kinetics, thermodynamics, and transport tool suite)

@mefuller mefuller mentioned this pull request Oct 9, 2021
@awvwgk
Copy link
Member

awvwgk commented Jan 1, 2022

This project currently does not support fpm. Therefore closing this PR.

@awvwgk awvwgk closed this Jan 1, 2022
@mefuller
Copy link
Author

mefuller commented Jan 2, 2022

Hi @awvwgk , can you point to documentation or instructions as to what the project would require for inclusion into FPM?
I would be happy to look into developing the necessary patch.
Thanks

@awvwgk
Copy link
Member

awvwgk commented Jan 2, 2022

I can see that Cantera provides Fortran bindings, however those are currently not directly usable from fpm without declaring Cantera as external/system dependency:

[build]
link = ["cantera"]
external-modules = ["cantera"]

The registry lists packages which can be used as dependencies in fpm, e.g.:

[dependencies]
cantera.git = "https://github.com/Cantera/cantera"

Which is currently not possible, because fpm does not support foreign build system like scons (yet).


I see two possible ways forward to make Cantera available for fpm:

  1. provide a package with declares Cantera as external/system dependency, preferable build the Fortran bindings as part of the fpm package to avoid incompatibilities with different Fortran compilers
  2. extend fpm to provide support for scons and build Cantera with fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants