Minor fixes: to list_files and mkdir in fpm_filesystem #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to ensure consistency between Windows and Linux: mkdir will not fail if dir already exists; list_files will include hidden files but exclude '.' and '..'
milancurcic
approved these changes
Oct 19, 2020
|
Bump. Let's get one more review here before merging. |
|
Looks fine. |
|
Thank you! Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by @urbanjost, there are inconsistencies in the behaviour of our
mkdirandlist_filesfilesystem routines on Windows and Linux.PR implements the following fixes:
mkdirwill not fail if dir already exists;list_fileswill include hidden files but exclude '.' and '..'