-
Notifications
You must be signed in to change notification settings - Fork 108
Refactor backend for incremental rebuilds #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Separate build targets into schedule regions for parallel builds.
Move enumeration of link target object dependencies out of backend and into fpm_targets module. Add string_cat function for concatenating arrays of string_t. Add comments and procedure descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works really well so far. I had a few issues when switching branches with git and rebuilding, but those might also result from incompatible module files left in the build directory (I would clean the build directory anyway for those cases). So no real failures so far, which is great.
Just some minor comments below.
Lowercase openmp pragmas
Thanks for reviewing; suggestions applied.
I've been having this issue with the bootstrap version but can't find the source of the problem. I haven't (yet) encountered this problem with this Fortran implementation — I will look into it for a future PR 👍 |
Maybe I encountered this while running |
Many thanks for reviewing; I'll merge later today if there are no more comments. |
Apparently there is an issue with an old version of Firefox working with the reviews. I thought I had approved this days ago but I noticed it is not checked. Others comments covered my issues so I have no problem with this going forward. Sorry if that caused a delay. Hopefully this works from this browser. |
This PR contains the required changes to implement incremental rebuilds (Resolves #212):
openmp
(bootstrap:fpm build --flag -fopenmp --flag -O3
)