Skip to content

Fix enumeration of non-library link objects #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2020
Merged

Fix enumeration of non-library link objects #267

merged 4 commits into from
Dec 8, 2020

Conversation

LKedward
Copy link
Member

@LKedward LKedward commented Dec 3, 2020

  • Fixes Failure to build iso_varying_string #263 caused by missing out some non-library dependencies in link_objects list for executable targets.
  • Update target dependency test-suite to build and check the link_objects list for link targets
  • Update hello_complex_2 example package to include an indirectly use'd non-library module dependency

iso_varying_string now builds with Fortran fpm and unit tests pass (fpm test unit_test).

@LKedward
Fix: enumeration of executable link objects
f63a416 
Adds missing recursive discovery of non-library dependency objects for executable link object lists
@LKedward
Update: dependency tests for updated resolve_target_linking
0d6a0c5 
Add checks on the link object lists built for archives and executables in 'resolve_target_linking'
@LKedward
Update example package for indirect module use
418454c 
Update hello_complex_2 example package to add a non-library module that is indirectly used by an app in the same directory.
@everythingfunctional
Copy link
Member

👍 Thanks for fixing it @LKedward

awvwgk
awvwgk reviewed Dec 5, 2020
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just one whitespace comment from me.

@awvwgk awvwgk mentioned this pull request Dec 6, 2020
Closed
@LKedward
Copy link
Member Author

LKedward commented Dec 8, 2020

Thanks for reviewing @awvwgk. I'll merge later today if there are no more comments.

@LKedward LKedward merged commit 849db65 into fortran-lang:master Dec 8, 2020
@LKedward LKedward deleted the fix-link-objects branch December 8, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to build iso_varying_string
3 participants
@LKedward @everythingfunctional @awvwgk