Skip to content

Create specification for example section #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2020
Merged

Create specification for example section #280

merged 7 commits into from
Dec 10, 2020

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Dec 8, 2020 •
edited
Loading

  • Add manifest reference for example applications
  • Add example manifest type to Fortran fpm
  • Integrate example in build command
  • Allow running example applications in run command
  • Implement example in Haskell fpm as well

Fixes #275

@awvwgk awvwgk added fpm-fortran specification Issue regarding fpm manifest and model labels Dec 8, 2020
@awvwgk awvwgk marked this pull request as draft December 8, 2020 19:18
@awvwgk awvwgk force-pushed the example branch 3 times, most recently from 75e0705 to eaf7748 Compare December 9, 2020 09:57
@awvwgk awvwgk marked this pull request as ready for review December 9, 2020 17:50
everythingfunctional
everythingfunctional approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great jobbing adding to the Haskell version as well.

LKedward
LKedward approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awvwgk! Fortran implementation all looks good except for one typo.
I think you also need to update the Automatic target discovery section of the manifest-reference to include auto-examples.

@awvwgk
Copy link
Member Author

awvwgk commented Dec 10, 2020 •
edited
Loading

Thanks for the fast review, I will go ahead and merge this PR soonish (after #266).

@awvwgk awvwgk merged commit 6e6e6b5 into fortran-lang:master Dec 10, 2020
@awvwgk awvwgk deleted the example branch December 10, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everythingfunctional everythingfunctional everythingfunctional approved these changes

@LKedward LKedward LKedward approved these changes

Assignees
No one assigned
Labels
specification Issue regarding fpm manifest and model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow example as special executable type
3 participants
@awvwgk @everythingfunctional @LKedward