Skip to content

Add: support for detecting .f and .F files #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Add: support for detecting .f and .F files #294

merged 2 commits into from
Dec 14, 2020

Conversation

LKedward
Copy link
Member

This PR should allow some legacy projects to compile with some restructuring.
I've tested this successfully on minpack (mentioned in #107) and @ivan-pi's fortran-lsp (mentioned in #250).

This PR adds no internal logic for distinguishing fixed and free-form (#250), this is still left to the compiler.

Resolves: #107
Related: #250

@LKedward LKedward marked this pull request as draft December 10, 2020 16:01
@LKedward LKedward marked this pull request as ready for review December 10, 2020 16:02
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, since it is a small patch and allows to build more projects, I'm happy see this PR move forward.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LKedward
Copy link
Member Author

Thanks for reviewing, I'll merge now.

@LKedward LKedward merged commit 55db69e into fortran-lang:master Dec 14, 2020
@LKedward LKedward deleted the add-f-suffix branch December 14, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects including legacy files
3 participants