Remove: -ffast-math in gfortran default release flags #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
approved these changes
Dec 18, 2020
urbanjost
approved these changes
Dec 18, 2020
milancurcic
approved these changes
Dec 18, 2020
|
This PR is fine, as a quick fix, but it is not the long term solution because we are leaving a lot of performance on the table. So I opened an issue #329 to brainstorm a solution to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it has been agreed generally in previous discussions that
-ffast-mathshould be an opt-in option by the package maintainer rather than enabled by default. This PR therefore removes-ffast-mathfrom thegfortrandefault flags for--release.I encountered this because the stdlib testsuite does not pass with
fpm test --releasewhen using stdlib with fpm.