Skip to content

Hacky fix for the help test #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

Hacky fix for the help test #352

merged 2 commits into from
Mar 3, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Feb 7, 2021

Definitely not a beautiful solution, but gets the job done. This works with both Haskell and Fortran fpm for now, but we need a better way to handle such cases. See #179 and #328.

Closes #343

LKedward
LKedward approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awvwgk. Until fpm testing is expanded this is an acceptable solution IMO. Do we need to apply the same logic in new_test to replace this?

This was referenced Mar 2, 2021
Closed
Closed
@awvwgk awvwgk force-pushed the hacky-help-test branch from 9e369f3 to 0bc7b29 Compare March 2, 2021 21:57
@LKedward
Copy link
Member

LKedward commented Mar 3, 2021

Thanks. I think this is good to go so we can move forward with #253 etc.. 👍

@awvwgk awvwgk merged commit 72b960b into fortran-lang:master Mar 3, 2021
@awvwgk awvwgk deleted the hacky-help-test branch March 3, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKedward LKedward LKedward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fortran fpm help_test invokes fpm
2 participants
@awvwgk @LKedward