Skip to content

Split workflow for Haskell and Fortran fpm #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 30, 2021

Creates separate workflows for Haskell and Fortran fpm. Haskell fpm is build with stack as usual, Fortran fpm is build with fpm 0.2.0, and than used to bootstrap itself in a two step procedure.

Note, the Windows workflow is using git-bash instead of cmd or powershell, because I'm not a Windows user and not really familiar with cmd, powershell and bat-scripts.

Here is a test release created with the new workflow: https://github.com/awvwgk/fortran-package-manager/releases/tag/v0.2.0

@awvwgk awvwgk requested a review from LKedward March 30, 2021 17:53
@awvwgk awvwgk mentioned this pull request Mar 30, 2021
3 tasks
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The workflow looks much cleaner both in the CI and in the run_tests.sh script.

Am I right in thinking that at the moment, both workflow jobs are uploading assets on release; should we remove the upload steps from the stack-build job? Can we in fact remove the stack-build job altogether, or do we still need it currently?

The run_tests.sh script has been updated but not the windows bat script. Maintaining both run_tests scripts isn't ideal, I wonder whether we still need the bat script if the CI can just use the sh script under git bash. I don't think any us actively develop on Windows?

@awvwgk
Copy link
Member Author

awvwgk commented Mar 31, 2021

Let's separate the pruning step and the CI splitting. I'll open another PR to remove all Haskell fpm related parts from this project. This PR is just shuffling things in the CI around to get the same outcome as before, just by different means.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's separate the pruning step and the CI splitting.

Sounds good. I'm happy with this PR, cheers.

@awvwgk awvwgk merged commit a4e8d22 into fortran-lang:master Mar 31, 2021
@awvwgk awvwgk deleted the fpm-ci branch March 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants