Skip to content

Add compiler to build path #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

everythingfunctional
Copy link
Member

This is the first part of supporting #66

Note: This should be merged after #72

Copy link
Member

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks great. +1 to merge as far as I am concerned.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good!

makeBuildPrefix :: String -> Bool -> IO String
makeBuildPrefix compiler release =
-- TODO Figure out what other info should be part of this
-- Probably version, and make sure to not include path to the compiler
Copy link
Member

@LKedward LKedward May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think we will need compiler version eventually since they're not compatible between versions.

@milancurcic milancurcic merged commit 82d1465 into fortran-lang:master May 4, 2020
@everythingfunctional everythingfunctional deleted the AddCompilerToBuildPath branch May 5, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants