Skip to content

Fix executables linking #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2022
Merged

Fix executables linking #743

merged 3 commits into from
Sep 5, 2022

Conversation

LKedward
Copy link
Member

@LKedward LKedward commented Sep 4, 2022

  • Adds: new test packages for apps with non-module non-library source files (app_with_c and app_with_submodule)
  • Adds: new routine to collect non-module non-library source targets as link dependencies of the respective exectutables
    • Only link those sources in the same directory and in a subdirectory of the executable source file

Fixes #556 and #741

@LKedward LKedward linked an issue Sep 4, 2022 that may be closed by this pull request
Undefined reference to function while compiling .c and .cpp files. #741
Closed
zoziha
zoziha approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a quick fix, @LKedward .
This patch passed all tests, LGTM.

arteevraina
arteevraina approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This also fixes the test_hash_function linker issue we are facing in #729

@arteevraina arteevraina mentioned this pull request Sep 4, 2022
Open
awvwgk
awvwgk approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Looks good to me.

@LKedward
Copy link
Member Author

LKedward commented Sep 5, 2022

Thanks all for reviewing, I'll now merge.

@LKedward LKedward merged commit e2f00d8 into fortran-lang:main Sep 5, 2022
@LKedward LKedward deleted the fix-exe-linking branch September 5, 2022 18:15
@LKedward LKedward mentioned this pull request Oct 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@zoziha zoziha zoziha approved these changes

@arteevraina arteevraina arteevraina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined reference to function while compiling .c and .cpp files. Detect submodule dependencies
4 participants
@LKedward @awvwgk @zoziha @arteevraina