Skip to content

Update README with installation instructions #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Apr 23, 2022

Installation and integration instructions for fpm and meson.

@awvwgk awvwgk added the documentation Improvements or additions to documentation label Apr 23, 2022
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #66 (e39ba42) into main (fa4bcbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           2        2           
  Lines        1221     1221           
  Branches      456      456           
=======================================
  Hits         1084     1084           
  Misses         40       40           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4bcbd...e39ba42. Read the comment docs.

Copy link
Member

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Note that on Apple M1, when I install gfortran using conda-forge, the nested functions work in Debug mode, but in Release mode (-O3, etc.) the generated binary segfaults, if the nested function accesses a variable in the parent scope. So the test you added to Meson might not be sufficient, since it doesn't access a variable. I am not a fan of these tests anyway, they seem to slow down the configure step. I think for fpm at least, we should just understand the platform and compiler versions, and know what works and what doesn't, no need to test for it like this (also what about cross-compilation when you cannot even run the binary..).

Anyway, this one is good to merge. The above are just some more general thoughts.

@awvwgk
Copy link
Member Author

awvwgk commented Apr 23, 2022

Removed the check and added an option to disable the C-API. Our testsuite will verify whether a compiler fully supports our usage of nested functions or not.

@awvwgk awvwgk merged commit 281e9b9 into fortran-lang:main Apr 23, 2022
@awvwgk awvwgk deleted the doc branch April 23, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants