You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are many isnan functions are used in test_mean.f90, test_moment.f90, test_var.f90 and test_varn.f90 files. But isnan is not a fortran standard. So, NAG fortran compiler (nagfor) fail to build these files. What about using ieee_is_nan instead of isnan?
Thank you for testing stdlib. ieee_is_nan could be used indeed. ieee_arithmetic is already used to generate NaN in mean(), moment(), and var() functions.
If you have time, could you modify the tests and submit a PR, please?
There has been several discussions around NaN and its implementation (e.g., #147). A more general solution is needed. Meanwhile, using ieee_is_nan should be fine, and a better solution than using compiler-dependent is_nan.
Activity
jvdp1 commentedon Mar 18, 2020
Thank you for testing
stdlib
.ieee_is_nan
could be used indeed.ieee_arithmetic
is already used to generateNaN
inmean()
,moment()
, andvar()
functions.If you have time, could you modify the tests and submit a PR, please?
There has been several discussions around
NaN
and its implementation (e.g., #147). A more general solution is needed. Meanwhile, usingieee_is_nan
should be fine, and a better solution than using compiler-dependentis_nan
.Merge pull request #160 from sakamoti/master
sakamoti commentedon Mar 21, 2020
Thank you for merging pull request #160 . Close this issue.