Skip to content

Build with nagfor(7.0) is fail because of "isnan" #159

Closed
@sakamoti

Description

@sakamoti

There are many isnan functions are used in test_mean.f90, test_moment.f90, test_var.f90 and test_varn.f90 files. But isnan is not a fortran standard. So, NAG fortran compiler (nagfor) fail to build these files. What about using ieee_is_nan instead of isnan?

Activity

jvdp1

jvdp1 commented on Mar 18, 2020

@jvdp1
Member

Thank you for testing stdlib.
ieee_is_nan could be used indeed. ieee_arithmetic is already used to generate NaN in mean(), moment(), and var() functions.

If you have time, could you modify the tests and submit a PR, please?

There has been several discussions around NaN and its implementation (e.g., #147). A more general solution is needed. Meanwhile, using ieee_is_nan should be fine, and a better solution than using compiler-dependent is_nan.

added a commit that references this issue on Mar 20, 2020

Merge pull request #160 from sakamoti/master

fd4656d
sakamoti

sakamoti commented on Mar 21, 2020

@sakamoti
ContributorAuthor

Thank you for merging pull request #160 . Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jvdp1@sakamoti

        Issue actions

          Build with nagfor(7.0) is fail because of "isnan" · Issue #159 · fortran-lang/stdlib