-
Notifications
You must be signed in to change notification settings - Fork 187
Addition of TOCs in Markdown files #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nothing obviously amiss, except the vim plugin magic comment thing. Links for each routine are obviously useful and good to have. Subsection links (Description, etc.) don't seem useful, though. |
Thanks @nshaffer for the review. I will remove Vim comments and subsection links (Their are indeed all the same). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! My only suggestion is to remove the "Implemented" heading from the top of each spec file--it serves no purpose, and in some files it's incorrect (for example, in quadrature it lists some functions that aren't implemented).
Looks good to me.
…On Fri, Mar 20, 2020, at 5:24 PM, Milan Curcic wrote:
***@***.**** approved this pull request.
Looks great! My only suggestion is to remove the "Implemented" heading
from the top of each spec file--it serves no purpose, and in some files
it's incorrect (for example, in quadrature it lists some functions that
aren't implemented).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#158 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWBSHU6KY7IUAFNJYD3RIP3JZANCNFSM4LJWBG2A>.
|
Thank you @milancurcic. Suggestion applied. |
Ok. I will merge. Thank you for your comments. |
Some specs already contain multiple functions. So I thought it could be good to add TOCs for clarity.
Of course, it can be discussed/modified/removed, as usual.