adapt_CI: correction to avoid RANK>4 in Github actions #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Mar 26, 2020
milancurcic
approved these changes
Mar 26, 2020
|
Straightforward and approved. Merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found the issue in #161 for which the Github action failed due to too long times needed for the manual Makefiles.
The issue is that the tests for in-tree builds generate the
.f90fromfyppwith RANK = 15. Because these are generated before running the manual Makefiles (and that there is no cleaning), the manual Makefiles do not generate them anymore, and try to compile all the.f90files generated with RANK=15 (instead of RANK=4 as for CMake).This proposition fixes this issue (and will fix the issue in #161 once merged there).
Times needed for the checks are also now more manageable.