Skip to content

Linter not work on windows 10 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
machsix opened this issue Mar 10, 2019 · 1 comment
Closed

Linter not work on windows 10 #116

machsix opened this issue Mar 10, 2019 · 1 comment

Comments

@machsix
Copy link
Contributor

machsix commented Mar 10, 2019

I'm using windows 10 with gfortran installed through msys2. I have set the location of gfortran as C:\msys64\usr\bin\gfortran.exe. Extension like FORTRAN IntelliSense work without problem. However, linter doesn't work even for a simple code like the following

program main
    implicit none
    x = 1
    y = 1
    write(*,*) x
end program

The problem panel is empty. Whenever I save the file, the following information pops up in the console of developer tool:

[Extension Host] child process exited with code false

I have tried to add C:\msys64\usr\include to the path of include, it doesn't help. Thanks for your help and I would like to provide other information needed.

@pedro-ricardo
Copy link
Collaborator

I'm very sorry @machsix but I can't help you with that. I've never tested the extension in any windows and won't install one just to do so =].
But Pull Requests are always welcome.
If you find the time, take a look at the code and see if you can debug what is wrong in your OS. It's probably something simple, since we had a merged pull request (#10) to solve aparently that same thing.

@pedro-ricardo pedro-ricardo mentioned this issue Mar 16, 2019
7 tasks
krvajal pushed a commit that referenced this issue Mar 17, 2019
In previous version, to make linter works on Windows, there are the following three requirements:
1. Install `MinGW-x64` version `gfortran` compiler. NOT MSYS2, NOT Cygwin. Only `MinGW-x64` can run natively on windows. You can install it by first install [mysys2](https://www.msys2.org/) and then run `pacman -Syu` and ` pacman -S mingw-w64-x86_64-toolchain`.
2. Add the `bin` directory to the `PATH` environment variable, for my case, it's `C:\msys64\mingw64\bin`
3. Add the path of `gfortran` to the `Gfortran Excutable`, for my case, it's `C:\msys64\mingw64\bin\gfortran.exe`

This PR removes the second requirement since editing `PATH` globally can ruin other program. The fix extracts the path of `bin` directory of `gfortran` and adds it to the `PATH` of `child_process`

Fix #116
@machsix machsix closed this as completed Mar 18, 2019
krvajal pushed a commit that referenced this issue Mar 26, 2019
### Check List
- [x] Merge #120 suggestion of #105
- [x] Merge #112 for fix on issue #110
- [x] Merge #117 for fix on issue #115
- [x] Merge #118 for fix on issue #116
- [x] Merge #122 for fix on issue #113
- [x] Update CHANGELOG.md
- [x] Update Package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants